[Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Aug 18 22:18:12 MSK 2020


On 18.08.2020 00:14, Cyrill Gorcunov wrote:
> On Mon, Aug 17, 2020 at 10:49:23PM +0200, Vladislav Shpilevoy wrote:
>> It seems this commit is not needed - I dropped it and nothing changed.
>> Even no merge/rebase conflicts.
>>
>> On 17.08.2020 15:39, Cyrill Gorcunov wrote:
>>> We need to access first and last xrow in a queue
>>> frenquently and opencoded variants are too ugly.
>>
>> frenquently -> frequently.
> 
> The code is ugly as hell without it :/

There are many ugly things, but it does not mean we need to rush
changing them. It was discussed already many times. Please, drop
this commit. It is not necessary. It does not interfere with the
other patches in a single line.


More information about the Tarantool-patches mailing list