[Tarantool-patches] [PATCH v8 5/9] qsync: direct write of CONFIRM/ROLLBACK into a journal

Cyrill Gorcunov gorcunov at gmail.com
Tue Aug 18 01:16:21 MSK 2020


On Mon, Aug 17, 2020 at 10:49:19PM +0200, Vladislav Shpilevoy wrote:
> > +	if (journal_write(entry) != 0 || entry->res < 0) {
> > +		diag_set(ClientError, ER_WAL_IO);
> > +		diag_log();
> > +		/*
> > +		 * XXX: the stub is supposed to be removed once it is defined what to do
> > +		 * when a synchro request WAL write fails. One of the possible
> > +		 * solutions: log the error, keep the limbo queue as is and probably put
> > +		 * in rollback mode. Then provide a hook to call manually when WAL
> > +		 * problems are fixed. Or retry automatically with some period.
> 
> Still out of 80 symbols.

Shame on me :( You already pointed and I remember this problem, but then
been rebasing and it flew out of my head. I could force push update if
this is the only problem.


More information about the Tarantool-patches mailing list