[Tarantool-patches] [PATCH v7 7/8] applier: process synchro requests without txn engine

Cyrill Gorcunov gorcunov at gmail.com
Mon Aug 17 15:42:35 MSK 2020


On Sat, Aug 15, 2020 at 05:06:05PM +0200, Vladislav Shpilevoy wrote:
> > +static struct synchro_entry *
> > +synchro_entry_new(struct applier *applier,
> > +		  struct xrow_header *applier_row,
> > +		  struct synchro_request *req)
> > +{
> > +	struct synchro_entry *entry;
> > +	size_t size = sizeof(*entry) + sizeof(struct xrow_header *);
> 
> 6. Why don't you just add 'struct xrow_header*[1]' to the end of
> struct synchro_entry? There is no a case, when the entry is needed
> without the xrow_header pointer in the end.

This is forbidden by asan and some other compilers we've in travis runs.
I've been already trying.

Thanks for all comments, Vlad. I've merged your changes. Once tests
are passed I'll send new series out.


More information about the Tarantool-patches mailing list