[Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on checkpoint

[Konstantin Osipov]

* Nikita Pettik <korablev at tarantool.org> [20/04/27 18:20]:
> > > Checkpoint daemon uses directly box.snapshot(), so now we can't tell
> > > whether checkpoint is launched manually or automatically. To differ
> > > these scenarious we can make checkpoint daemon call sort of
> > > box.__scheduled_snapshot() (which won't be part of public API ofc).
> > > Then we will be able to pass boolean parameter to begin_checkpoint()
> > > indicating manual/auto mode. Or simply close issue as wont fix :)
> > 
> > Uhm, no, checkpoint daemon uses gc_do_checkpoint() and it doesn't
> > use box.snapshot().
> 
> Seems we are looking at different branches: 1.10 still uses checkpoint
> daemon written in Lua. If this patch should be pushed to master branch
> only, then I guess it would be easy to patch engine_begin_checkpoint()
> and make it accept argument responsible for checkpoint mode (scheduled
> or manual).

Why do you need to fix 1.10?

-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com