[Tarantool-patches] [PATCH v2 0/2] Name columns in a different way

Roman Khabibov roman.habibov at tarantool.org
Mon Apr 27 02:08:58 MSK 2020


Should I squash these patches into one patch?

Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3962-column
Issue: https://github.com/tarantool/tarantool/issues/3962
Issue: https://github.com/tarantool/tarantool/issues/4545

@ChangeLog:
- Name auto generated columns as “COLUMN_N” instead of “_auto_name_”
or span of the original expression.
- Don't make column names unique by printing "_1" to the end during
<FROM> processing.

Roman Khabibov (2):
  sql: use unify pattern for column names
  sql: don't modify column names

 src/box/sql/select.c                         |  49 +--
 src/box/sql/sqlInt.h                         |  15 +
 test/box/function1.result                    |  12 +-
 test/sql-tap/colname.test.lua                | 207 ++++-------
 test/sql-tap/select1.test.lua                |  21 +-
 test/sql-tap/select6.test.lua                |  22 +-
 test/sql-tap/view.test.lua                   |   6 +-
 test/sql/bind.result                         |  42 +--
 test/sql/boolean.result                      | 360 +++++++++----------
 test/sql/collation.result                    |  14 +-
 test/sql/errinj.result                       |   2 +-
 test/sql/foreign-keys.result                 |   4 +-
 test/sql/full_metadata.result                |  23 +-
 test/sql/func-recreate.result                |   2 +-
 test/sql/gh-3199-no-mem-leaks.result         |  24 +-
 test/sql/gh-3888-values-blob-assert.result   |   8 +-
 test/sql/gh-4104-view-access-check.result    |   2 +-
 test/sql/gh-4104-view-access-check.test.lua  |   2 +-
 test/sql/gh-4545-no-col-name-modify.result   |  33 ++
 test/sql/gh-4545-no-col-name-modify.test.sql |  10 +
 test/sql/icu-upper-lower.result              |  82 ++---
 test/sql/integer-overflow.result             |  14 +-
 test/sql/iproto.result                       |  18 +-
 test/sql/max-on-index.result                 |   6 +-
 test/sql/misc.result                         |  12 +-
 test/sql/persistency.result                  |  66 ++--
 test/sql/prepared.result                     |  36 +-
 test/sql/row-count.result                    |  40 +--
 test/sql/transition.result                   |  66 ++--
 test/sql/types.result                        | 224 ++++++------
 30 files changed, 683 insertions(+), 739 deletions(-)
 create mode 100644 test/sql/gh-4545-no-col-name-modify.result
 create mode 100755 test/sql/gh-4545-no-col-name-modify.test.sql

-- 
2.21.0 (Apple Git-122)



More information about the Tarantool-patches mailing list