[Tarantool-patches] [PATCH v2 1/2] coio/say: fix getaddrinfo error handling on macOS
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Sun Apr 26 20:20:59 MSK 2020
Hi! I didn't review the patch. Just noticed, that you need the
stacked diag in one place, and I have a comment on that.
> diff --git a/src/lib/core/say.c b/src/lib/core/say.c
> index 64a637c58..8ad88ad57 100644
> --- a/src/lib/core/say.c
> +++ b/src/lib/core/say.c
> @@ -593,6 +596,11 @@ log_syslog_init(struct log *log, const char *init_str)
> say_free_syslog_opts(&opts);
> log->fd = log_syslog_connect(log);
> if (log->fd < 0) {
> + /*
> + * We need to log a diagnostics here until stacked
> + * diagnostics will be implemented (#1148).
> + */
> + diag_log();
Stacked diagnostics is implemented now.
More information about the Tarantool-patches
mailing list