[Tarantool-patches] [PATCH v4 3/10] Fix luacheck warnings in extra/dist/tarantoolctl.in

Igor Munkin imun at tarantool.org
Thu Apr 23 14:40:37 MSK 2020


Sergey,

Thanks for the patch, LGTM!

On 21.04.20, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Reviewed-by: Igor Munkin <imun at tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Co-authored-by: Igor Munkin <imun at tarantool.org>
> ---
>  .luacheckrc                |  2 ++
>  extra/dist/tarantoolctl.in | 29 +++++++++++++----------------
>  2 files changed, 15 insertions(+), 16 deletions(-)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index 2683c8c26..0b7dc2dfe 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -24,3 +24,5 @@ exclude_files = {
>      ".rocks/**/*.lua",
>      ".git/**/*.lua",
>  }
> +
> +files["extra/dist/tarantoolctl.in"] = {ignore = {"212/self", "122", "431"}}

Side note: Please file a follow-up issue to fix a single (W122) warning:
| extra/dist/tarantoolctl.in:217:5: (W122) setting read-only field ? of global arg

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list