[Tarantool-patches] [PATCH] Add a check whether glibc is used

[lvasiliev]

Hi! Thanks for the feedback.

On 22.04.2020 18:36, Cyrill Gorcunov wrote:
> On Wed, Apr 22, 2020 at 05:52:18PM +0300, lvasiliev wrote:
>> Comment from code of cbus_hang test:
>> " We want to cancel canceled thread in the moment of cpipe_flush_cb
>>   will be processing.
>>   A Linux specific dirty hack will be used for reproduce the bug.
>>   We need to synchronize the main thread and the canceled worker thread.
>>   So, do it using the endpoint's mutex internal field(__data.__lock)."
>> "A Linux specific" - a glibc specific.
> 
> Aha! So it is test's specific. Pleas add this into changelog itself.
> Reviewed-by: Cyrill Gorcunov <gorcunov at gmail.com>
> 
Updated log message:

commit 3e21641638075fe0b8ad909a6a3ce0b064695906
Author: Leonid Vasiliev <lvasiliev at tarantool.org>
Date:   Tue Apr 21 19:16:17 2020 +0300

     Add a check whether glibc is used

     The cbus hang test uses glibc pthread mutex implementation details.
     The reason why mutex implementation details is used:
     "For the bug reproducing the canceled thread must be canceled
     during processing cpipe_flush_cb. We need to synchronize
     the main thread and the canceled worker thread for that.
     So, thread synchronization has been realized by means of
     endpoint's mutex internal field(__data.__lock)."
     Therefore, it should not compile in case of using another library.