[Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck
Sergey Bronnikov
sergeyb at tarantool.org
Wed Apr 22 13:14:29 MSK 2020
Hello,
On 22:33 Tue 21 Apr , Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! Please adjust the commit subject considering our
> contributors guide[1]. Since the commit is for tarantool/luajit repo I
> propose the following:
> | test: fix warnings spotted by luacheck
Updated on the branch.
> Also, It would be nice to mention in commit message that luacheck is
> integrated in tarantool CI pipeline that respect .luacheckrc in
> tarantool repo (since jit global is suppressed there).
>
> Furthermore I applied your patch and as a result of manual luacheck run
> in test directory I faced the following warnings:
Applied on the branch, thanks!
<snipped>
Sergey
More information about the Tarantool-patches
mailing list