[Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G

Igor Munkin imun at tarantool.org
Tue Apr 21 22:52:31 MSK 2020


Vlad,

Thanks for the patch! LGTM (feel free to push out of order as obvious).

Side note: I don't know whether we need a test for it (a simple lookup
for <update_format> and <role_check_grant_revoke_of_sys_priv> in _G) but
on the second thought it looks excess and out of the common practice.

On 21.04.20, sergeyb at tarantool.org wrote:
> From: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> 
> A couple of functions were mistakenly declared as 'function'
> instead of 'local function' in schema.lua. That led to their
> presence in the global namespace.
> ---
>  src/box/lua/schema.lua | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list