[Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/

Igor Munkin imun at tarantool.org
Fri Apr 17 15:13:43 MSK 2020


Sergey,

On 17.04.20, Sergey Bronnikov wrote:
> Igor, thanks for review!
> See my answers below.
> 
> On 23:51 Wed 15 Apr , Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch!
> > 

<snipped>

> > I see no reasons to leave other W212[unused argument self] occurences.
> > Here is a diff:
> 
> Vladislav already told me in previous review iterations that '_' is less
> readable than 'self', so it was a reason why haven't fixed them. I have
> found a way to supress only W212 related to 'self' and applied it in
> branch.

Nice! That's exactly what we need for this issue!

> 
> S.

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list