[Tarantool-patches] [PATCH] say: fix syslog format
Igor Munkin
imun at tarantool.org
Fri Apr 17 14:56:49 MSK 2020
Olya,
Thanks, LGTM now.
Side note: I shared the recipe about diff pasting via vim[1] and hope it
is helpful.
On 17.04.20, Olga Arkhangelskaia wrote:
> Igor, thanks a lot for your patience.
>
> I have fixed all nits you have mentioned.
>
> See diff below!
>
<snipped>
> 12 src/lib/core/say.c | 14 ++++++++--
> 13 test/box-tap/gh-4785-syslog.test.lua | 42
> ++++++++++++++++++++++++++++
> 14 2 files changed, 54 insertions(+), 2 deletions(-)
> 15 create mode 100755 test/box-tap/gh-4785-syslog.test.lua
> -
> 26 +`....../*
> 27 +`...... * When logger type is SAY_LOGGER_BOOT it simply prints
> 28 +`...... * every message to stdout intact and can't be formatted.
> 29 +`...... * SAY_LOGGER_SYSLOG type uses the well-documented and
> 30 +`...... * *recommended* format described in the RFC below:
> 31 +`...... * https://tools.ietf.org/html/rfc3164#section-4.1
> 32 +`...... * Thereby format can't be changed for this type either.
> 33 +`...... */
> 34 +`......bool unchangeable = log_default->type == SAY_LOGGER_BOOT ||
> 35 +`......`.......`....... log_default->type == SAY_LOGGER_SYSLOG;
> 36 +`......if (unchangeable)
<snipped>
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016121.html
--
Best regards,
IM
More information about the Tarantool-patches
mailing list