[Tarantool-patches] [PATCH] sql: fix number and boolean sorting rules
Timur Safin
tsafin at tarantool.org
Fri Apr 17 10:27:20 MSK 2020
As a random bypasser I could not resist and not add my 5 kopecks (see below).
: -----Original Message-----
: From: Mergen Imeev <imeevma at tarantool.org>
:
: Hi! Thank you for the fixes. I think that the your
: commit-message and comments sounds quite strange, but I am
: not sure that I am qualified enough to say that for sure.
: Please, send this patch to NIkita. Other than that, LGTM.
:
: > commit 8a2133d84b88a050181d858d6109abf3635a121b (HEAD ->
: romanhabibov/gh-4697-scalar-bug, origin/romanhabibov/gh-4697-scalar-bug)
: > Author: Roman Khabibov <roman.habibov at tarantool.org>
: > Date: Mon Apr 13 05:03:54 2020 +0300
: >
: > sql: fix number and boolean SCALAR sorting rules
: >
: > Make comparison SCALAR rules in the sql sorter correct for number
: > and boolean. Boolean should always follow before any number.
: >
: > Closes #4697
: >
Agreed with Mergen that message is confusing, I'd suggest to do this simple replacement to make it clearer
s/follow before/precede/g
Regards,
Timur
More information about the Tarantool-patches
mailing list