[Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Thu Apr 16 00:40:59 MSK 2020
>> diff --git a/src/lua/fiber.lua b/src/lua/fiber.lua
>> index 89c17f63d..692408e54 100644
>> --- a/src/lua/fiber.lua
>> +++ b/src/lua/fiber.lua
>> @@ -40,7 +40,7 @@ fiber.stall = nil
>>
>> local worker_next_task = nil
>> local worker_last_task = nil
>
> It looks like this assignment can also be omitted (anyway luacheck also
> reports it as a warning).
It didn't report for me.
>> -local worker_fiber = nil
>> +local worker_fiber
>>
>> --
>> -- Worker is a singleton fiber for not urgent delayed execution of
>
> <snipped>
>
>> diff --git a/src/lua/msgpackffi.lua b/src/lua/msgpackffi.lua
>> index 9105c3f23..793f47854 100644
>> --- a/src/lua/msgpackffi.lua
>> +++ b/src/lua/msgpackffi.lua
>> @@ -501,7 +501,11 @@ local ext_decoder = {
>> -- MP_DECIMAL
>> [1] = function(data, len) local num = ffi.new("decimal_t") builtin.decimal_unpack(data, len, num) return num end,
>
> I guess MP_DECIMAL decoder can also be transformed to multiline function.
It can, but luacheck does not complain about it (on my machine),
so I decided to keep it to reduce diff size.
More information about the Tarantool-patches
mailing list