[Tarantool-patches] [PATCH] vclock: rename vclock_reset to vclock_set

Cyrill Gorcunov gorcunov at gmail.com
Wed Apr 15 19:21:05 MSK 2020


On Wed, Apr 15, 2020 at 07:09:02PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [20/04/15 17:16]:
> > The `reset` keyword is too overloaded, its traditional
> > context is to setup some value either to zero or to default.
> > 
> > That is not what we're doing in this helper: we rather set up
> > a new value to the replica_id in the map, keeping consistency
> > of the sum.
> 
> > Thus lets name it as it should -- vclock_set.
> 
> Well, one could argue that it's impossible to set a vclock
> component without violating consistency - vclock should never go
> back. 
> 
> reset() indicates that it can unwind the clock.

Didn't you just named it in correct way -- vlock_unwind() ;-)
Anyway, we've been talking about this name in tchat and
I gave up. Drop the patch please.


More information about the Tarantool-patches mailing list