[Tarantool-patches] [PATCH 11/12] popen: clarify popen_read_timeout error message

Cyrill Gorcunov gorcunov at gmail.com
Wed Apr 15 10:39:30 MSK 2020


On Wed, Apr 15, 2020 at 07:21:36AM +0300, Alexander Turenko wrote:
> >  
> >  	if (!(flags & (POPEN_FLAG_FD_STDOUT | POPEN_FLAG_FD_STDERR))) {
> > -		diag_set(IllegalParams, "popen: POPEN_FLAG_FD_STD{OUT,ERR} are "
> > -			 "unset both");
> > +		diag_set(IllegalParams,
> > +			 "popen: neither stdout nor stderr is choosen");
> >  		return -1;
> >  	}
> 
> I was inattentive: there is an error message of the same style in
> popen_read_timeout(). Those functions should be changed both together.

I think better "popen: neither stdout nor stderr is set", but no
strong preferences here (except there is no such word as 'choosen')


More information about the Tarantool-patches mailing list