[Tarantool-patches] [PATCH 08/12] popen: fix close-on-exec flag setting

[Cyrill Gorcunov]

On Tue, Apr 14, 2020 at 02:38:17PM +0300, Alexander Turenko wrote:
> fcntl(2) lists flags that can be set using F_SETFL: O_CLOEXEC is not
> included there. F_SETFD should be used to set close-on-exec.
> 
> Parent's end of pipes are closed explicitly in a child process anyway.
> However this change fixes closing of the copy of a logger fd. See commit
> 07a07b3cc7b85375d20b3fc6ca1e5060304f337b ('popen: decouple logger fd
> from stderr') for more information why this file descriptor was
> introduced.
> 
> Part of #4031.

Good catch!
Acked-by: Cyrill Gorcunov <gorcunov at gmail.com>