[Tarantool-patches] [PATCH v3 0/6] Add static analysis with luacheck

[Sergey Bronnikov]

Changelog:

- removed asserts in test/ to keep following diff-based approach with tests
- added separate install target in .travis.mk
- added comment regarding ENABLE_DIST in .travis.mk
- enabled app-tap in .luacheckrc
- removed duplicate warnings W212 and W122
- disabled checking of files in test/var directory

GH issue: https://github.com/tarantool/tarantool/issues/4681
GitHub branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4681-fix-luacheck-warnings

Sergey Bronnikov (6):
  Fix luacheck warnings in src/lua/
  Fix luacheck warnings in test/
  Fix luacheck warnings in src/box/lua/
  Fix luacheck warnings in extra/dist/tarantoolctl.in
  Add luacheck config
  gitlab-ci: enable static analysis with luacheck

 .gitlab-ci.yml                                |   9 +
 .luacheckrc                                   | 175 ++++++++++++++++++
 .travis.mk                                    |  15 +-
 extra/dist/tarantoolctl.in                    |  18 +-
 src/box/lua/upgrade.lua                       |  12 +-
 src/lua/argparse.lua                          |   6 +-
 src/lua/buffer.lua                            |   4 +-
 src/lua/clock.lua                             |   2 +-
 src/lua/crypto.lua                            |   4 +-
 src/lua/csv.lua                               |   5 +-
 src/lua/digest.lua                            |   2 +-
 src/lua/env.lua                               |   2 +-
 src/lua/fio.lua                               |  25 +--
 src/lua/httpc.lua                             |   3 -
 src/lua/init.lua                              |   7 +-
 src/lua/msgpackffi.lua                        |  16 +-
 src/lua/socket.lua                            |  65 ++++---
 src/lua/string.lua                            |   1 -
 src/lua/swim.lua                              |  10 +-
 src/lua/tap.lua                               |  74 ++++----
 src/lua/trigger.lua                           |   3 -
 test/app-tap/console.test.lua                 |   4 -
 test/app-tap/csv.test.lua                     |  28 +--
 test/app-tap/logger.test.lua                  |   2 +-
 test/box-py/box.lua                           |   2 +-
 test/box-tap/gc.test.lua                      |   4 +-
 test/box/box.lua                              |   2 +-
 test/box/hash_multipart.result                |   2 +-
 test/box/hash_multipart.test.lua              |   2 +-
 test/box/lua/cfg_bad_vinyl_dir.lua            |   2 +-
 test/box/lua/cfg_rtree.lua                    |   2 +-
 test/box/lua/cfg_test1.lua                    |   2 +-
 test/box/lua/cfg_test2.lua                    |   2 +-
 test/box/lua/cfg_test3.lua                    |   2 +-
 test/box/lua/cfg_test4.lua                    |   2 +-
 test/box/lua/cfg_test5.lua                    |   4 +-
 test/box/lua/cfg_test6.lua                    |   2 +-
 test/box/lua/utils.lua                        |   3 +-
 test/box/on_schema_init.lua                   |   2 +-
 test/box/proxy.lua                            |   2 +-
 test/box/tiny.lua                             |   2 +-
 test/box/tree_pk.result                       |   4 +-
 test/box/tree_pk.test.lua                     |   4 +-
 test/engine/tree_min_max_count.result         |   2 +-
 test/engine/tree_min_max_count.test.lua       |   2 +-
 test/replication-py/master.lua                |   2 +-
 test/replication-py/panic.lua                 |   2 +-
 test/replication/master.lua                   |   2 +-
 test/replication/replicaset_ro_mostly.result  |   2 +-
 .../replication/replicaset_ro_mostly.test.lua |   2 +-
 test/sql-tap/analyze3.test.lua                |   6 +-
 test/sql-tap/analyze9.test.lua                |  16 +-
 .../gh-4077-iproto-execute-no-bind.test.lua   |   7 +-
 test/sql-tap/index1.test.lua                  |   1 -
 test/sql-tap/join3.test.lua                   |   2 +-
 test/sql-tap/select9.test.lua                 |  10 +-
 test/sql-tap/tkt-fa7bf5ec.test.lua            |   6 +-
 test/sql-tap/where2.test.lua                  |   2 +-
 test/sql/lua/sql_tokenizer.lua                |   2 +-
 test/sql/savepoints.result                    |   6 +-
 test/sql/savepoints.test.lua                  |   6 +-
 test/sql/triggers.result                      |   2 +-
 test/sql/triggers.test.lua                    |   2 +-
 test/vinyl/large.lua                          |   3 +-
 test/vinyl/txn_proxy.lua                      |   6 +-
 test/vinyl/vinyl.lua                          |   2 +-
 test/wal_off/rtree_benchmark.result           |   2 +-
 test/wal_off/rtree_benchmark.test.lua         |   2 +-
 test/xlog-py/box.lua                          |   2 +-
 test/xlog/panic.lua                           |   2 +-
 test/xlog/reader.result                       |   2 +-
 test/xlog/reader.test.lua                     |   2 +-
 test/xlog/snap_io_rate.test.lua               |   2 +-
 test/xlog/transaction.result                  |   2 +-
 test/xlog/transaction.test.lua                |   2 +-
 test/xlog/xlog.lua                            |   2 +-
 76 files changed, 409 insertions(+), 243 deletions(-)
 create mode 100644 .luacheckrc

-- 
2.23.0


-- 
sergeyb@