[Tarantool-patches] [PATCH 00/43] Unhide symbols
Konstantin Osipov
kostja.osipov at gmail.com
Mon Apr 13 17:15:34 MSK 2020
* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [20/04/13 16:57]:
> > Basically the right fix is to remove this link option, not come up
> > with 43 patches.
>
> It is not enough. Static library symbols are not exported, if they
> are not used. Linker drops them. It means almost all needed symbols
> are removed when you just remove the option.
>
> Alternative is to use option all_load on clang (and whole-archive on
> gcc), but that exports *all* symbols and *all* functions. Even the
> ones which really are not needed, but are just a part of some library,
> which we don't want to trim.
This is a single user feature. That single user was happy with the
previous implementation, using automatic exports. Clang, Mac OS X
or unstable export lists were not relevant to him, so a tiny patch
reverting linker option would suffice.
You are trying to make it "better" for that user. As I wrote
earlier, this won't work, since nobody's going to maintain these
lists going forward.
It is actually quite amazing how Nick made a useless patch 4 years
ago and it spawned hours of useless conversations and emails, and
43 other useless patches now, and I don't know how many more
useless patches and emails will be written to keep this
going...
Since whatever happens it's not relevant to tarantool architecture
or code quality I don't really care - except it's a pity people
are spending time on this instead of spending it on something
more useful.
--
Konstantin Osipov, Moscow, Russia
More information about the Tarantool-patches
mailing list