[Tarantool-patches] [PATCH] Fix flaky test engine/ddl
Sergey Bronnikov
sergeyb at tarantool.org
Mon Apr 13 16:06:12 MSK 2020
Hi!
Sergey, thanks for review.
On 15:55 Sat 11 Apr , Serge Petrenko wrote:
> Hi! Thanks for the patch!
>
> I think the check can’t fail after `box.snapshot()` even without wait_cond().
> You’ve already waited for the index to build right before `box.snapshot()`.
> It’ s better to leave the last 2 checks without wait_cond to emphasize that
> nothing could happen during `box.snapshot()`.
You are wrong. Test is failed when wait_cond() below 'box.snapshot()' removed.
S.
More information about the Tarantool-patches
mailing list