[Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl
lvasiliev
lvasiliev at tarantool.org
Mon Apr 13 10:44:24 MSK 2020
Hi. Thanks you for the feedback!
On 12.04.2020 21:30, Yaroslav Dynnikov wrote:
> Hi, guys.
>
> Recently we talked to Leonid in chat and discussed the necessity of
> removing flags. I've offered Leonid to check behavior, so here is what
> I've found.
>
> My point of view (now and then) is that they're neither useful nor
> harmful. Earlier I did agree to blacklist them, but looking at Leonids
> patch set this week I've changed my mind as the second commit seems
> just worthless to me.
>
> Inline help says:
>
> ```
> --lua-dir=<prefix> Which Lua installation to use.
> --lua-version=<ver> Which Lua version to use.
> --global Use the system tree when `local_by_default` is
> `true`.
> --local Use the tree in the user's home directory.
> To enable it, see
> '/opt/tarantool-install/bin/tarantoolctl help path'.
>
> Rocks trees in use:
> /tmp/tmp.JY1fgy8La9/.rocks ("user")
> /opt/tarantool-install ("system")
> ```
>
> * Tarantool does define `LOCAL_BY_DEFAULT = true`,
> (i.e. `--local` is our default behavior)
>
> * "System tree" is the place where tarantool is installed
> (`-DCMAKE_INSTALL_PREFIX`).
>
> * "Home directory" in tarantool is overriden with `./.rocks`.
>
> * See "rocks: update luarocks to 3.1.1" 4222c1f6
> <https://github.com/tarantool/tarantool/commit/4222c1f6451973f446f9c8be28c7012435416fa3>.
>
> * Both `--local` and `--global` are only shortcuts for predefined
> `--tree=<tree>`, which isn't going to be removed.
>
> * Speaking of `--lua-dir` and `--lua-version`, they look to be neither
> useful nor harmful.
>
Do I understand correctly that you propose to discard the commit with
deleting flags?
> Please, notice that command-line help refers to `tarantoolctl help
> path`, but
>
> 1. It should be `tarantoolctl rocks help` (I guess there are many of
> such places)
It was commented by Vlad
> 2. `rocks path` command is disabled in your patch.
>
Rocks path was disabled before my patch and it wasn't at the list (list
from ticket https://github.com/tarantool/tarantool/issues/4629) of
desired commands to include. Do you propose to add the "path" command?
> I'm a lazy developer and I don't like unnecessary restrictions. If I
> were you, I'd drop the second commit ("Delete flags which can't be used
> with tarantoolctl rocks" 1b51b2f) and enable back `rocks path` command.
> Let people decide whether they need it or not.
>
> Finally, a few words about documentation. I've tried to write down all
> supported commands and flags, and I found it's really difficult and
> verbose. I'm withdrawing my suggestion to clarify it, I don't know what
> to do. Perhaps, documentation should just refer to inline help, as it's the
> only up-to-date information, and still correct enough.
>
Ok
> Дынников Ярослав.
More information about the Tarantool-patches
mailing list