[Tarantool-patches] [PATCH 0/4] CMake option to remove feedback daemon

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Apr 12 23:13:26 MSK 2020


There is a complaint that the feedback daemon is a 'spying' tool
and because of that can't be used on Gentoo. Its default disabled
option also is not acceptable, the daemon should be eliminated
completely.

The patchset introduces cmake option ENABLE_FEEDBACK_DAEMON. It is
ON by default. When set to OFF, all feedback daemon's code is not
included into the binary, its configuration options disappear.

The issue is closed in the last commit, but there appeared some
side tasks necessary to make it work, these are first 3 commits.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3308-cmake-remove-feedback
Issue: https://github.com/tarantool/tarantool/issues/3308

Vladislav Shpilevoy (4):
  box: improve built-in module load panic message
  feedback: move feedback code to the single file
  box: yield after initial box_cfg() is finished
  feedback: add cmake option to disable the daemon

 src/box/CMakeLists.txt                | 10 ++++++++-
 src/box/box.cc                        | 15 +++++++++++++-
 src/box/lua/feedback_daemon.lua       | 16 +++++++++++++++
 src/box/lua/init.c                    | 13 ++++++++++--
 src/box/lua/load_cfg.lua              | 29 +++++++++++++++++++++------
 src/box/lua/schema.lua                | 17 ----------------
 src/trivia/config.h.cmake             |  2 ++
 test/box-tap/feedback_daemon.test.lua | 23 +++++++++++++++++----
 test/box/misc.result                  | 19 ++++++++++++++++--
 test/box/misc.test.lua                | 15 +++++++++++++-
 10 files changed, 125 insertions(+), 34 deletions(-)

-- 
2.21.1 (Apple Git-122.3)



More information about the Tarantool-patches mailing list