[Tarantool-patches] [PATCH v2 1/1] box: export box_session_push to the public C API

[Igor Munkin]

Vlad,

On 11.04.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 

<snipped>

> 
> > The result value is not checked, but <port_msgpack_set_plain> returns -1
> > when OOM occurs.
> 
> No need to check result. port_mspack_set_plain() not only returns -1, it
> also keeps port->plain NULL. If it is NULL, it is an error.
> 
> port_mspack_dump_plain() returns port->plain. Therefore if there was an
> error, it will return NULL with a correctly installed diag.

OK, thanks, got it. It might be useful to drop a couple words regarding
it. Feel free to ignore.

-- 
Best regards,
IM