[Tarantool-patches] [PATCH v2 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in
Sergey Bronnikov
sergeyb at tarantool.org
Fri Apr 10 17:05:27 MSK 2020
Oleg, thanks. Updated in the branch.
On 10:30 Thu 09 Apr , Oleg Babin wrote:
> Hi! Thanks for your patch! See my comment below.
>
> On 08/04/2020 18:43, Sergey Bronnikov wrote:
> > From: Sergey Bronnikov <sergeyb at tarantool.org>
> >
> > @@ -420,7 +419,7 @@ local cat_formats = setmetatable({
> > json = cat_json_cb,
> > lua = cat_lua_cb,
> > }, {
> > - __index = function(self, cmd)
> > + __index = function(cmd)
> > error(("Unknown formatter '%s'"):format(cmd))
> > end
> > })
>
> You can't simply drop "self" argument. See [1]. I assume that a change that
> doesn't break behaviour is "function(_, cmd)".
>
>
> [1] https://www.lua.org/pil/13.4.1.html
>
> ---
> Oleg Babin
--
sergeyb@
More information about the Tarantool-patches
mailing list