[Tarantool-patches] [PATCH 05/13] say: allow to set a logger file descriptor

Cyrill Gorcunov gorcunov at gmail.com
Fri Apr 10 11:33:49 MSK 2020


On Fri, Apr 10, 2020 at 05:50:43AM +0300, Alexander Turenko wrote:
...
>  
>  /**
> - * Default logger file descriptor.
> + * Accessors for default logger file descriptor.
> + *
> + * It is needed for dark magic inside popen implementation.
> + * Unlikely it is what you want to use anywhere else.
>   */

I would rather comment it as "It is needed to keep the
logger fd alive if a child process in the popen engine
needs own fd intersecting with logger." But up to you.

Acked-by: Cyrill Gorcunov <gorcunov at gmail.com>


More information about the Tarantool-patches mailing list