[Tarantool-patches] [PATCH 2/2] vinyl: clean-up read views if *_build_history() fails

Konstantin Osipov kostja.osipov at gmail.com
Thu Apr 9 11:19:23 MSK 2020


* Nikita Pettik <korablev at tarantool.org> [20/04/09 00:39]:
>  	if (vy_write_iterator_build_history(stream, &raw_count,
> -					    &is_first_insert) != 0)
> +					    &is_first_insert) != 0) {
> +		for (int i = 0; i < stream->rv_count; ++i)
> +			stream->read_views[i].history = NULL;

This violates stream encapsulation and should be a method of the
stream. 

Otherwise lgtm.


-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list