[Tarantool-patches] [PATCH v11 5/8] box/replication: merge replica_by_id into replicaset

Konstantin Osipov kostja.osipov at gmail.com
Mon Apr 6 10:40:16 MSK 2020


* Cyrill Gorcunov <gorcunov at gmail.com> [20/04/05 05:06]:
> For some reason the replica_by_id member (which is an
> array of pointers) is allocated dynamically. Moreover
> VCLOCK_MAX = 32 by now and extending it to some new
> limit will require a way more efforts than just increase
> the number.
> 
> Thus reserve memory for replica_by_id inside replicaset
> statically. This allows to simplify code a bit and
> drop calloc/free calls.
> 
> The former code comes from edd76a2a0ae17e3d without any
> explanation why the dynamic member is needed.

lgtm


-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list