[Tarantool-patches] [PATCH v2 0/2] box: fix session.push formatting
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Sat Apr 4 02:42:45 MSK 2020
Thanks for the fixes!
The patchset LGTM. Except that the changelog is still
missing.
Please, add a changelog, and send on a second review.
I propose either Nikita or Alexander L.
On 13/03/2020 15:58, Chris Sosnin wrote:
> issue: https://github.com/tarantool/tarantool/issues/4686
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt
>
> Changes in v2:
> - Current format moved to struct session.
> - Applied review fixes.
>
> Chris Sosnin (2):
> refactoring: store output format in struct session
> box: fix formatting in session.push
>
> extra/exports | 2 +
> src/box/lua/console.c | 53 ++++++++++++++++++--------
> src/box/lua/console.lua | 72 +++++++++++++++++++++++++++--------
> src/box/session.h | 22 ++++++++---
> test/app-tap/console.test.lua | 14 ++++++-
> 5 files changed, 126 insertions(+), 37 deletions(-)
>
More information about the Tarantool-patches
mailing list