[Tarantool-patches] [PATCH v1 1/1] sql: remove implicit cast for COMPARISON

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Apr 3 02:47:41 MSK 2020


>>>> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
>>>> index 1579cc9..cd626bd 100644
>>>> --- a/src/box/sql/sqlInt.h
>>>> +++ b/src/box/sql/sqlInt.h
>>>> @@ -1304,6 +1304,9 @@ enum trim_side_mask {
>>>>  				 (X) == FIELD_TYPE_UNSIGNED || \
>>>>  				 (X) == FIELD_TYPE_DOUBLE)
>>>>  
>>>> +#define sql_mp_type_is_numeric(X)  ((X) == MP_INT || (X) == MP_UINT || \
>>>> +				    (X) == MP_FLOAT || (X) == MP_DOUBLE)
>>>
>>>
>>> 7. Is there a ticket to stop conveting MEM_* to MP_*?
>>
>> Hm, I thought I created once such ticket, but in fact failed to
>> find it. If you are OK with suggestion below concerning splitting
>> mem type into two members, I'll open an issue.
>>
> Does anyony mind if I do all this here, before main patch-set?

I am ok with that. But you need to do it quick then, because
the release is close.


More information about the Tarantool-patches mailing list