[Tarantool-patches] [PATCH v2 06/10] box: introduce stacked diagnostic area

Nikita Pettik korablev at tarantool.org
Thu Apr 2 17:16:35 MSK 2020


On 02 Apr 02:29, Vladislav Shpilevoy wrote:
> Thanks for the answers!
> 
> On 31/03/2020 19:44, Nikita Pettik wrote:
> > On 28 Mar 19:59, Vladislav Shpilevoy wrote:
> >> Two more comments.
> >>
> >>> diff --git a/test/box/error.test.lua b/test/box/error.test.lua
> >>> index a0b7d3e78..1fdd6ed98 100644
> >>> --- a/test/box/error.test.lua
> >>> +++ b/test/box/error.test.lua
> >>> @@ -108,4 +108,109 @@ box.error.new(err)
> >>> +
> >>>  space:drop()
> >>
> >> 1. You probably need to keep this 'space:drop()' after
> >> the test related to it.
> > 
> > Isn't it too late?:) I mean test it is related to is finished at
> > line 20, meanwhile space:drop() is already at line 111 (box/error.test.lua
> > is already pushed).
> 
> You still can add 1148 tests after space:drop, not before. In
> that case it at least won't become worse than it is.

Ok, placed space:drop() before #1148 test cases.
 


More information about the Tarantool-patches mailing list