[Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks module

lvasiliev lvasiliev at tarantool.org
Thu Apr 2 10:35:58 MSK 2020


Hi, thanks for the review.

On 01.04.2020 14:33, Igor Munkin wrote:
> Leonid,
> 
> Thanks for the series! Considering your post-review fixups and omitting
> other comments I have regarding the tarantoolctl code, it LGTM.
> 
> Please add a ChangeLog entry for your patchset.
Done 
(https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all)

@Changelog
Fixed the tarantoolctl rocks search flag --all

and

@Changelog
Fixed the tarantoolctl rocks remove flag --force
> 
> Sasha, please proceed with the series.
> 
> On 16.03.20, Leonid Vasiliev wrote:
>> https://github.com/tarantool/tarantool/issues/3632
>> https://github.com/tarantool/tarantool/issues/4529
>> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all
>>
>> Some new options (--all and --force) have been added to the white-list for forwarding to the tarantoolctl rocks module.
>>
>> Leonid (2):
>>    luarocks: Add a kludge for option all of luarocks search
>>    luarocks: Add a kludge for option force of luarocks remove
>>
>>   extra/dist/tarantoolctl.in | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> -- 
>> 2.17.1
>>
> 


More information about the Tarantool-patches mailing list