[Tarantool-patches] [PATCH v2 1/5] static build: speedup build

[Sergey Bronnikov]

LGTM

On 12:26 Thu 19 Dec , Alexander Tikhonov wrote:
> Igor, thanks for the review, I've made comment correction as you suggested.
> 
> 
> >Среда, 18 декабря 2019, 15:23 +03:00 от Igor Munkin <imun at tarantool.org>:
> >
> >Sasha,
> >
> >Thanks, the changes LGTM except the one minor comment: I guess it's
> >preferable to have a sole 'build:' tag for any patch related to the
> >build system. Feel free to ignore and proceed if Sasha Tu. (he's already
> >CCed as a second reviewer) has no remarks to the subj.
> >
> >On 10.12.19, Alexander V. Tikhonov wrote:
> >> Added '-j' option to make for tools buildings, it decreased build time in 4 times.
> >> ---
> >>  Dockerfile.staticbuild | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> >> index d63c18bd1..8da8ae304 100644
> >> --- a/Dockerfile.staticbuild
> >> +++ b/Dockerfile.staticbuild
> >> @@ -44,7 +44,7 @@ RUN set -x && \
> >>      tar -xvf openssl-1.1.0h.tar.gz && \
> >>      cd openssl-1.1.0h && \
> >>      ./config --libdir=lib && \
> >> -    make && make install
> >> +    make -j && make install
> >> 
> >>  RUN set -x && \
> >>      cd / && \
> >> @@ -52,7 +52,7 @@ RUN set -x && \
> >>      tar -xvf icu4c-62_1-src.tgz && \
> >>      cd icu/source && \
> >>      ./configure --with-data-packaging=static --enable-static --enable-shared && \
> >> -    make && make install
> >> +    make -j && make install
> >> 
> >>  RUN set -x && \
> >>      cd / && \
> >> @@ -60,7 +60,7 @@ RUN set -x && \
> >>      tar -xvf libunwind-1.3-rc1.tar.gz && \
> >>      cd libunwind-1.3-rc1 && \
> >>      ./configure --enable-static --enable-shared && \
> >> -    make && make install
> >> +    make -j && make install
> >> 
> >>  COPY . /tarantool
> >> 
> >> -- 
> >> 2.17.1
> >> 
> >
> >-- 
> >Best regards,
> >IM
> 
> 
> -- 
> Alexander Tikhonov

-- 
sergeyb@