[tarantool-patches] Re: [PATCH v3 1/4] box: an ability to disable CK constraints

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/09/16 15:49]:
> +space_ck_constraint_set_state

I think set_state is more general than necessary.
space_ck_constraint_enable is fine, even if it can be used to 
disable the constraint as well.
> +ck_constraint_mt.enable = function(ck_constraint, yesno)

Especially if Lua wrapper is called enable.

Generally, if you select a name, you stick to it more
or less throughout the call chain (the same is true for variable
names).

> --- a/src/box/memtx_engine.c
> +++ b/src/box/memtx_engine.c
> @@ -35,6 +35,7 @@
>  #include <small/small.h>
>  #include <small/mempool.h>
>  
> +#include "ck_constraint.h"
>  #include "fiber.h"
>  #include "errinj.h"
>  #include "coio_file.h"

Why is this stray include?


-- 
Konstantin Osipov, Moscow, Russia