[tarantool-patches] Re: [PATCH v2 4/4] replication: use wal memory buffer to fetch rows

[Konstantin Osipov]

* Georgy Kirichenko <georgy at tarantool.org> [19/09/18 12:39]:
> +			if (relay->version_id < version_id(1, 7, 4))
> +				send_vclock = &relay->r->vclock;
> +			else
> +				send_vclock = &relay->recv_vclock;

I think it is better to drop 1.7.x support going forward - it
will never be tested and is most likely to get broken by the
changes, so better to refuse to peer with 1.7.x than break in some
strange way. Whoever wants to use the new replication features
needs to upgrade to 1.10 first. So please add a patch which
throws a nice error when an old peer like 1.7.x  connects or when
connecting to an old peer.

-- 
Konstantin Osipov, Moscow, Russia