[tarantool-patches] Re: [PATCH v2 1/3] box: an ability to disable CK constraints

[Kirill Shcherbatov]

> Please, add reasoning. Please, explain why do we need per constraint
> options? Why not disable them all at once? How to disable constraint
> in SQL?
> 
> What is more, I'd split this patch into two: first one introduces
> 'is_enabled' property; second one provides check execution during
> force recovery.
https://www.techonthenet.com/oracle/check.php

ALTER TABLE suppliers
ENABLE CONSTRAINT check_supplier_id;
> Could you make result of test be clearer? From .result file it is not
> obvious that check verification failed.
test_run:wait_log('default', 'ER_CK_CONSTRAINT_FAILED: Check constraint failed \'ck_unnamed_TEST_1\': a < 10', nil, 5)


All other comments are obviously accounted or they become outdated.