[tarantool-patches] [PATCH 0/2] tarantoolctl --show-system

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Sep 19 02:00:29 MSK 2019


The patchset fixes incorrect handling of flag-parameters in tarantoolctl and its
module - argparse.

The only flag parameter now is '--show-system'. And an attempt to specify it
appeared to be quite non-trivial task. It was not possible to set any value for
this parameter, and it was showing weird error messages. This was because of how
argparse module, used by tarantoolctl to parse arguments, stored parameters not
having a value, and how checked boolean parameters.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4076-tarantoolctl-show-system
Issue: https://github.com/tarantool/tarantool/issues/4076

Vladislav Shpilevoy (2):
  app: fix boolean handling in argparse module
  app: fix error messages for not specified parameters in argparse

 src/lua/argparse.lua       | 37 ++++++++++-------
 test/app/argparse.result   | 84 ++++++++++++++++++++++++++++++++++++--
 test/app/argparse.test.lua | 32 +++++++++++++++
 3 files changed, 135 insertions(+), 18 deletions(-)

-- 
2.20.1 (Apple Git-117)





More information about the Tarantool-patches mailing list