[tarantool-patches] Re: [PATCH v3 0/5] refactoring: remove exceptions from triggers

[Georgy Kirichenko]

I'm sorry but the patchset is mostly unreviewable and unmergeable.
Please split each patch into small independent parts, for instance - 
1. txn_alter_trigger_new doesn't throw
2. tnt_raise -> diag_set() return -1; at some 1-2-3 triggers
3. use non _xc version of function in some triggers
4 ....
So we could review and merge a big count of small diffs even if you made 
mistakes in others.

Additionally you forgot about some exceptions like fiber_testcancel <- 
replica_on_applier_connect <- replica_on_applier_state_f

Also, please don't change code indentation without any reason.

I fixed the first patch and attached diff to the reply, you could rebase your 
changes against it.

On Wednesday, September 11, 2019 4:05:14 PM MSK Ilya Kosarev wrote:
> Triggers don't throw exceptions any more. Now they have
> return codes to report errors.
> 
> Changes in v3:
> 1) Style fixes: switch .. case, indentation
> 2) In some patches extra diag_raise calls are removed
> 
> Branch:
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4247-remove-except
> ions-from-triggers Issue: https://github.com/tarantool/tarantool/issues/4247
> 
> Ilya Kosarev (5):
>   refactoring: remove exceptions from triggers except alter.cc
>   refactoring: remove exceptions from used in alter.cc outer functions
>   refactoring: replace exceptions in most alter.cc  functions
>   refactoring: remove obvious exceptions in alter.cc
>   refactoring: replace remaining exceptions in alter.cc & update
>     comments
> 
>  src/box/alter.cc            | 2704 ++++++++++++++++++++++-------------
>  src/box/applier.cc          |   18 +-
>  src/box/ck_constraint.c     |    9 +-
>  src/box/ck_constraint.h     |    4 +-
>  src/box/identifier.h        |   10 -
>  src/box/iproto.cc           |    3 +-
>  src/box/lua/call.c          |    5 +-
>  src/box/lua/sequence.c      |    3 +-
>  src/box/lua/space.cc        |    3 +-
>  src/box/memtx_space.c       |   17 +-
>  src/box/relay.cc            |    5 +-
>  src/box/replication.cc      |   75 +-
>  src/box/replication.h       |    2 +-
>  src/box/schema.cc           |   28 +-
>  src/box/schema.h            |   17 +-
>  src/box/sequence.h          |    9 -
>  src/box/session.cc          |    3 +-
>  src/box/tuple.h             |   69 -
>  src/box/txn.c               |   10 +-
>  src/box/user.cc             |    9 +-
>  src/box/user.h              |   14 +-
>  src/box/vinyl.c             |   44 +-
>  src/box/vy_scheduler.c      |    3 +-
>  src/lib/core/fiber.c        |    3 +-
>  src/lib/core/trigger.cc     |   23 +-
>  src/lib/core/trigger.h      |    2 +-
>  src/lua/trigger.c           |    7 +-
>  src/main.cc                 |    3 +-
>  test/unit/cbus.c            |    3 +-
>  test/unit/swim.c            |    6 +-
>  test/unit/swim_test_utils.c |    3 +-
>  31 files changed, 1887 insertions(+), 1227 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.diff
Type: text/x-patch
Size: 48693 bytes
Desc: not available
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190918/df7c20e9/attachment.bin>