[tarantool-patches] Re: [PATCH v1] build: LTO release build fails

[Vladislav Shpilevoy]

Hi! I am ok with the patch. What I don't understand is
why it was working earlier, before my patches in the master.

The problematic variables always were declared without an
initial value, I didn't touch that part. But it was building
ok. What has changed? Me and Alexander T. have failed to find
a reason (although I didn't try super hard :) ).

On 20/09/2019 16:14, Alexander Turenko wrote:
> LGTM.
> 
> To be honest, I don't like such changes, because 0 is not some special
> value here: it is part of range of valid variable values. But it worth
> to keep -Wmaybe-uninitialized warning, because sometimes it gives useful
> input; see:
> 
> https://github.com/tarantool/tarantool/commit/e55396c87e2560540bc46f3b8935bee8d8b057d7
> (re struct http_praser)
> https://github.com/tarantool/tarantool/commit/c308f35d8807dd08d8c0b6e281fa2391d3c31161
> (re xrow_decode_*())
> 
> CCed Vlad to give glance on this too.
> 
> WBR, Alexander Turenko.
>