[tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs

Kirill Yukhin kyukhin at tarantool.org
Thu Sep 26 08:11:52 MSK 2019


On 09 сен 21:00, Vladislav Shpilevoy wrote:
> The patchset fixes several problems about JSON and msgpack serializers.
> 1) msgpackffi didn't use msgpack serializer options;
> 2) tuple serializer either;
> 3) update of a serializer option was not reflected in its Lua representation;
> 4) during serialization too nested tables are silently cropped and there was no
>   way to prevent it.
> Also it was discovered, that msgpackffi does not care *all* options. Not only
> about max_depth. I am not sure if it is worth fixing here (or at all) though.
> Changes in v2:
> - Renames;
> - Default value a flag for whether we need to raise an error on a too nested msgpack (was crop, now error).
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg
> Issue: https://github.com/tarantool/tarantool/issues/4434

I've checked your patch set into 1.10, 2.1, 2.2 and master.

Regards, Kirill Yukhin

More information about the Tarantool-patches mailing list