[tarantool-patches] Re: [PATCH 1/4] tuple: expose JSON go_to_key and go_to_index functions

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Sep 16 21:43:27 MSK 2019


Hi! Thanks for the review!

On 16/09/2019 09:03, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/09/16 09:58]:
>> They are needed in JSON path update for a case, when a final part
>> of the path may not exist, and go_to_path returns an error.
>>
>> That case is '=' and '!' on not existing fields. For example,
>> in {'=', '[1][2][3]', 20} field [3] can be not existing.
>>
>> For these cases JSON update will have its own implementation of
>> go_to_path allowing optional last field.
>>
>> Needed for #1261
>> ---
> 
> lgtm
> 
> 

Talking of lgtms, I don't know what to do next after your lgtm.
Who should review and push it now?




More information about the Tarantool-patches mailing list