[tarantool-patches] Re: [PATCH 4/4] tuple: remove some dependencies on struct tuple_update and rope

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/09/16 09:58]:
> Function do_op_insert() was depending on struct tuple_update
> because of 'region' field. In next patches struct tuple_update
> will be on much more high level of API than do_op_insert and such
> a dependency would be wrong. Drop it.
> 
> Functions update_read_ops(), update_finish(),
> tuple_upsert_squash() were depending on update_alloc() function
> intended to be used by rope only. Rope will migrate down to lower
> API in next patches, so this dependency should not exist.

lgtm

Please keep in mind that today transaction memory is separate from
update memory. But update data doesn't seem to be important for
transaction control, so it should be fine to keep it in fiber
memory (volatile stuff).


-- 
Konstantin Osipov, Moscow, Russia