[tarantool-patches] Re: [PATCH 1/1] box: raise an error on nil replicaset and instance uuid

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Sep 7 16:28:35 MSK 2019



On 07/09/2019 15:26, Vladislav Shpilevoy wrote:
> Before the patch the nil UUID was ignored and a new random one
> was generated. This was because internally box treats nil UUID
> as its absense.

'absense' -> 'absence'.

> 
> Now a user will see an explicit message that nil UUID is a
> reserved value.
> 
> Closes #4282
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid
> Issue: https://github.com/tarantool/tarantool/issues/4282
> 
>  src/box/box.cc            | 25 +++++++++++++++++--------
>  test/app-tap/cfg.test.lua | 12 +++++++++++-
>  2 files changed, 28 insertions(+), 9 deletions(-)
> 
> diff --git a/src/box/box.cc b/src/box/box.cc
> index ac10c21ad..5efc88d5f 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -480,22 +480,31 @@ box_check_replication_sync_timeout(void)
>  	return timeout;
>  }
>  
> +static inline void
> +box_check_uuid(struct tt_uuid *uuid, const char* name)

Sorry, '*' should be right before 'name'.
(Messed with Ubisoft code style)




More information about the Tarantool-patches mailing list