[tarantool-patches] Re: [PATCH 1/6] box/console: Add mapping for direct symbols

Cyrill Gorcunov gorcunov at gmail.com
Mon Sep 9 18:54:22 MSK 2019


On Mon, Sep 09, 2019 at 06:11:44PM +0300, Sergey Ostanevich wrote:
>    Cyrill,
> 
>    Why not to move the map_direct_symbols to the module level, so that
>    creation and
>    fill of the table will happens only once and not at every call to the
>    output handler?

Well, initially I thought to keep such things inside serializer helper
so that if we need we will easily extend this table and the change
will be inside function context. I must admit I think all this comes
from a strong habbit of working with compilers where such thing would
be simply optimized. That said I agree we should do so.

I think this issue could be addressed on top as a separate patch?
Just to not resend the whole series.




More information about the Tarantool-patches mailing list