[tarantool-patches] Re: [PATCH 1/1] test: move luajit-tap suite to luajit repo
alexander.turenko at tarantool.org
Tue Sep 10 17:17:03 MSK 2019
Maybe update the commit to update luajit submodule here, when we'll push
the patch to the luajit default branch (named 'tarantool')?
While we are here, it worth to update the branch in .gitmodules (now it
points to 'tarantool-1.7', but should point to 'tarantool'). If one will
use git submodule update --remote, then it can confuse. Can be done
right in this commit, just mention it in the commit message.
Out-of-source build missed small and luajit-tap test suites (it is
already so for small). Don't sure whether it should block the commit.
See more in the luajit's patch review:
WBR, Alexander Turenko.
On Thu, Sep 05, 2019 at 05:01:53PM +0300, Igor Munkin wrote:
> * All test chunks related to luajit were moved from tarantool source
> tree to the luajit repo
> * Adjusted CMakeLists via creating a symlink to luajit test directory
> to fix out-of-source tests
> Closed #4478
> .gitignore | 1 +
> test/CMakeLists.txt | 10 +
> test/luajit-tap/fold_bug_LuaJIT_505.test.lua | 20 --
> test/luajit-tap/gh.test.lua | 17 --
> test/luajit-tap/suite.ini | 5 -
> .../table_chain_bug_LuaJIT_494.test.lua | 178 ------------------
> test/luajit-tap/unsink_64_kptr.test.lua | 44 -----
> 7 files changed, 11 insertions(+), 264 deletions(-)
> delete mode 100755 test/luajit-tap/fold_bug_LuaJIT_505.test.lua
> delete mode 100755 test/luajit-tap/gh.test.lua
> delete mode 100644 test/luajit-tap/suite.ini
> delete mode 100755 test/luajit-tap/table_chain_bug_LuaJIT_494.test.lua
> delete mode 100755 test/luajit-tap/unsink_64_kptr.test.lua
More information about the Tarantool-patches