[tarantool-patches] Re: [PATCH 4/5] box/console: Fix hang in remote console lua mode

Cyrill Gorcunov gorcunov at gmail.com
Wed Sep 4 10:12:00 MSK 2019


On Wed, Sep 04, 2019 at 09:46:57AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/09/03 22:45]:
> > > why self.eos but global output_eos? 
> > 
> > because this is not global output but the value bound
> > to a particular session, you can have one server and
> > several clients, where each client have own eos
> > setting. Same applies to next your comment. So that
> > why we need to carry it into object instance.
> 
> I mean, why the variable name is different?

Well, to point that it is related to "self" object
and don't collide with global output_eos when grepping
the source code. But I odn't have strong preference here
will rename. Thanks!




More information about the Tarantool-patches mailing list