[tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs
alexander.turenko at tarantool.org
Fri Sep 13 02:44:01 MSK 2019
On Mon, Sep 09, 2019 at 09:00:06PM +0200, Vladislav Shpilevoy wrote:
> The patchset fixes several problems about JSON and msgpack serializers.
> 1) msgpackffi didn't use msgpack serializer options;
> 2) tuple serializer either;
> 3) update of a serializer option was not reflected in its Lua representation;
> 4) during serialization too nested tables are silently cropped and there was no
> way to prevent it.
> Also it was discovered, that msgpackffi does not care *all* options. Not only
> about max_depth. I am not sure if it is worth fixing here (or at all) though.
I would not do it here. However it worth to file a follow up issue: we
should either fix or document this behaviour. It seems that it may be
very unexpected that space:update / upsert does not follow, say,
encode_invalid_numbers (if a user use this option and see that it works
for other box functions).
> Changes in v2:
> - Renames;
> - Default value a flag for whether we need to raise an error on a too nested msgpack (was crop, now error).
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg
> Issue: https://github.com/tarantool/tarantool/issues/4434
The pathset looks mostly okay for me. I gave LGTM (with some minor
comments) for the first three patches. I would discuss the option name
in the fourth patch.
WBR, Alexander Turenko.
More information about the Tarantool-patches