[tarantool-patches] Re: [PATCH 2/2] wal: drop rows_per_wal option

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Sep 8 15:53:42 MSK 2019


Changed a constant and its comment, as asked by Kostja:

diff --git a/src/box/wal.h b/src/box/wal.h
index 2ddc008ff..b76b0a41f 100644
--- a/src/box/wal.h
+++ b/src/box/wal.h
@@ -45,13 +45,11 @@ enum wal_mode { WAL_NONE = 0, WAL_WRITE, WAL_FSYNC, WAL_MODE_MAX };
 
 enum {
 	/**
-	 * Such a value originates from the old setting
-	 * 'rows_per_wal'. By default it was 500000, and its
-	 * value was used to decide how often wal writer needs
-	 * to yield, by formula: (rows_per_wal >> 4) + 1. With
-	 * default rows_per_wal it was equal to this constant.
+	 * Recovery yields once per that number of rows read and
+	 * applied from WAL. It allows not to block the event
+	 * loop for the whole recovery stage.
 	 */
-	WAL_ROWS_PER_YIELD = 31251,
+	WAL_ROWS_PER_YIELD = 32000,
 };




More information about the Tarantool-patches mailing list