[tarantool-patches] Re: [PATCH v1] test: avoid of too long running sql-tap tests

[Alexander Turenko]

LGTM.

Pushed to master, 2.2 and 2.1.

WBR, Alexander Turenko.

On Mon, Sep 02, 2019 at 08:53:30AM +0300, Alexander V. Tikhonov wrote:
> The test sql-tap/gh-3083-ephemeral-unref-tuples.test.lua took
> too long runtime and failed to finish in timeout limit of 2
> minutes when it runs near the end of the running queue:
> 
> No output during 120 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
> - 012_sql-tap [sql-tap/gh-3083-ephemeral-unref-tuples.test.lua, vinyl] at var/012_sql-tap/gh-3083-ephemeral-unref-tuples.result:0
> Test hung! Result content mismatch:
> [File does not exists: sql-tap/gh-3083-ephemeral-unref-tuples.result]
> [Main process] No output from workers. It seems that we hang. Send SIGKILL to workers; exiting...
> 
> Due to suggestion from Konstantin Osipov at gh-3845:
> https://github.com/tarantool/tarantool/issues/3845#issue-385735959
> 
> The following tests:
>   gh-3083-ephemeral-unref-tuples.test.lua
>   gh-3332-tuple-format-leak.test.lua
> where set to run only on memtx configuration.
> 
> Also the test:
>   gh-3083-ephemeral-unref-tuples.test.lua
> was removed from the test-run 'fragile' option flaky list.
> 
> Closed #4128
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4128-disable-vinyl-test-3083
> Issue: https://github.com/tarantool/tarantool/issues/4128
> 
>  test/sql-tap/engine.cfg | 6 ++++++
>  test/sql-tap/suite.ini  | 3 +--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/test/sql-tap/engine.cfg b/test/sql-tap/engine.cfg
> index dc64bbdbc..693a477b7 100644
> --- a/test/sql-tap/engine.cfg
> +++ b/test/sql-tap/engine.cfg
> @@ -14,6 +14,12 @@
>      "sort.test.lua": {
>          "memtx": {"engine": "memtx"}
>      },
> +    "gh-3083-ephemeral-unref-tuples.test.lua": {
> +        "memtx": {"engine": "memtx"}
> +    },
> +    "gh-3332-tuple-format-leak.test.lua": {
> +        "memtx": {"engine": "memtx"}
> +    },
>      "gh-4077-iproto-execute-no-bind.test.lua": {},
>      "*": {
>          "memtx": {"engine": "memtx"},
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index ec10383ae..8f3c3eab1 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -29,6 +29,5 @@ long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.te
>  config = engine.cfg
>  show_reproduce_content = False
>  pretest_clean = True
> -fragile = gh-3083-ephemeral-unref-tuples.test.lua ; gh-4128
> -          gh-4077-iproto-execute-no-bind.test.lua ; gh-4459
> +fragile = gh-4077-iproto-execute-no-bind.test.lua ; gh-4459
>            selectG.test.lua                        ; gh-4458
> -- 
> 2.17.1
>