[tarantool-patches] Re: [PATCH 1/1] test: move luajit-tap suite to luajit repo

[Alexander Turenko]

I missed the magic word: LGTM :)

CCed Kirill.

WBR, Alexander Turenko.

On Tue, Sep 10, 2019 at 06:49:24PM +0300, Igor Munkin wrote:
> 
> Sasha,
> 
> Thanks for you review.
> >Вторник, 10 сентября 2019, 17:17 +03:00 от Alexander Turenko <alexander.turenko at tarantool.org>:
> >
> >Maybe update the commit to update luajit submodule here, when we'll push
> >the patch to the luajit default branch (named 'tarantool')?
> >
> >While we are here, it worth to update the branch in .gitmodules (now it
> >points to 'tarantool-1.7', but should point to 'tarantool'). If one will
> >use git submodule update --remote, then it can confuse. Can be done
> >right in this commit, just mention it in the commit message.
> Totally agree with your remark and as discussed I propose the following:
> *  Update submodule to the required branch within a separate commit (not included in current branch)

Okay, it is on you.

> *  Apply the patch with luajit-tap tests to tarantool/luajit repo (the patch mentioned below)
> *  Apply another patch removing corresponding tests from tarantool source tree
> Kirill, if you have another workflow for such modifications, I'm open for a discussion.

I'm okay with updating the submodule within this commit or in a separate
commit: this is the minor thing. If we'll separate them I only vote to
update the submodule first: consider, for example performing git bisect
using one of tests from luajit-tap.

I also vote to push it to all long-term branches down to 1.10, because
most of luajit-related commits are for all branches (as bugfixes): it
will be convenient to have uniform testing machinery.

> >
> >Out-of-source build missed small and luajit-tap test suites (it is
> >already so for small). Don't sure whether it should block the commit.
> >See more in the luajit's patch review:
> >https://www.freelists.org/post/tarantool-patches/PATCH-11-test-add-tests-from-tarantool-source-tree,1

BTW, filed https://github.com/tarantool/tarantool/issues/4485

> >On Thu, Sep 05, 2019 at 05:01:53PM +0300, Igor Munkin wrote:
> >> * All test chunks related to luajit were moved from tarantool source
> >> tree to the luajit repo
> >> * Adjusted CMakeLists via creating a symlink to luajit test directory
> >> to fix out-of-source tests
> >> 
> >> Closed #4478
> >> ---
> >>  .gitignore                                    |   1 +
> >>  test/CMakeLists.txt                           |  10 +
> >>  test/luajit-tap/fold_bug_LuaJIT_505.test.lua  |  20 --
> >>  test/luajit-tap/gh.test.lua                   |  17 --
> >>  test/luajit-tap/suite.ini                     |   5 -
> >>  .../table_chain_bug_LuaJIT_494.test.lua       | 178 ------------------
> >>  test/luajit-tap/unsink_64_kptr.test.lua       |  44 -----
> >>  7 files changed, 11 insertions(+), 264 deletions(-)
> >>  delete mode 100755 test/luajit-tap/fold_bug_LuaJIT_505.test.lua
> >>  delete mode 100755 test/luajit-tap/gh.test.lua
> >>  delete mode 100644 test/luajit-tap/suite.ini
> >>  delete mode 100755 test/luajit-tap/table_chain_bug_LuaJIT_494.test.lua
> >>  delete mode 100755 test/luajit-tap/unsink_64_kptr.test.lua
> 
> 
> -- 
> IM