[Tarantool-patches] [PATCH v4 4/4] http: add CURLE_BAD_CONTENT_ENCODING case for curl_request code
Alexander Turenko
alexander.turenko at tarantool.org
Tue Oct 29 02:42:57 MSK 2019
The code LGTM; see several comments about the description below.
WBR, Alexander Turenko.
> http: add CURLE_BAD_CONTENT_ENCODING case for curl_request code
I would write something like that as the commit header:
| httpc: handle bad Content-Encoding with curl-7.67.0+
It give a reader the reason why we doing this; also it simplify schedule
the patch to proper branches; now we see that it is needed to support
more broad libcurl version range.
> Currently in case of unknown encoding curl returns CURLE_WRITE_ERROR
> request code. Since curl/curl#4449 CURLE_BAD_CONTENT_ENCODING request code
Fit a commit message body in 72 symbols.
> will be returned in this case. Therefore mentioned case has to be
> added into switch clause processing curl request code.
How about such description?
| libcurl-7.66.0 and older returns CURLE_WRITE_ERROR when a server
| responds with unknown or not supported Content-Encoding (see [1] and
| [2]). This was fixed in future libcurl-7.67.0 and proper
| CURLE_BAD_CONTENT_ENCODING code will be returned in the case.
|
| We should process the code in the same way as we do for
| CURLE_WRITE_ERROR.
|
| [1]: issue link
| [2]: PR link
|
| Closes #4579
>
> Closes #4579
> ---
> src/httpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/httpc.c b/src/httpc.c
> index b493a8498..d3516049e 100644
> --- a/src/httpc.c
> +++ b/src/httpc.c
> @@ -447,6 +447,7 @@ httpc_execute(struct httpc_request *req, double timeout)
> case CURLE_COULDNT_RESOLVE_HOST:
> case CURLE_COULDNT_CONNECT:
> case CURLE_WRITE_ERROR:
> + case CURLE_BAD_CONTENT_ENCODING:
> /* 595 Connection Problem (AnyEvent non-standard) */
> req->status = 595;
> req->reason = curl_easy_strerror(req->curl_request.code);
> --
> 2.17.1
>
More information about the Tarantool-patches
mailing list